I stayed in Shanghai for 8 days, and split my stay up among 3 hotels, roughly at the same price point (about $110 U.S.). One was modern, for a soft landing in a new city. And then I chose the Astor for 2 nights, along with the Miller Villa for another 2 nights, to capture Old Shanghai opulence.
The Astor Hotel succeeded in that front. It was a bit faded, It was certainly quite glorious in its day, and is still quite nice (if a little rough around the edges in parts) now. And it is very convenient for walking and many nighttime activities (ie walks along the Bund, E. nanjing road, etc.). The subway stop on the useful #10 line is a bit of a trek (maybe around a mile, not sure though) along a sometimes quiet street.
My first room, a “classic room” at the second to lowest rate, smelled horribly (mold? Sewage? It was bad)
They changed my room to a considerably upgraded, super large and posh, historical room at no charge. I was impressed by their responsiveness.
The breakfast room is stunning. The breakfast itself is large, with a good deal of variety. This was more of a quantity-over-quality approach to Chinese breakfasts, I think. But I was so taken by the stunning dining room that I was happy.
History buffs may, like me, also consider a stay at the Motor Villa Hotel, in the former French Concession area. In my view, the Motor Villa is posher and more polished. But both are beautiful Grand Dame hotels, and both are worth a stay,